NULL pointer in imx-sdma.c with from context arg in reject_firmware_nowait

Denis 'GNUtoo' Carikli GNUtoo at
Mon May 28 16:31:53 UTC 2018

On Tue, 17 Apr 2018 10:41:29 +0200
Xavi Drudis Ferran <xdrudis at> wrote:

The patch below seem sensible to me:
> request_firmware_nowait(module, uevent, NONFREE_FIRMWARE,
> -				       device, gfp, NULL, cont);
> +				       device, gfp, context, cont);

However merging the patch without finding why the NULL was put there
doesn't seem a good idea as it could break many drivers along the way.

Would it be possible to try to find this information by:
- Finding when it was first introduced
- By looking at the ChangeLogs of the version introducing it

Note that I'm not a Linux-libre maintainer, here I'm just helping to
review the patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the linux-libre mailing list